Review Request 112570: Port some kde4_add_executable usages to add_executable

Aleix Pol Gonzalez aleixpol at kde.org
Mon Sep 9 16:49:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 4:49 p.m.)


Review request for KDE Frameworks.


Changes
-------

Adapted to changes suggested by David Faure.
Add some notes in KDE5PORTING.html
Actually be more consistent on how the TEST argument is handled now.


Description
-------

kde4_add_executable is deprecated. Port all kde4_add_executable uses to add_executable.


Diffs (updated)
-----

  KDE5PORTING.html b3329d6 
  experimental/kdeclarative/CMakeLists.txt a7bddfa 
  interfaces/terminal/example/CMakeLists.txt e8c3f01 
  kdesu/CMakeLists.txt 351ad85 
  kdewidgets/CMakeLists.txt 038da6b 
  khtml/CMakeLists.txt 124c3eb 
  kinit/CMakeLists.txt ff7b7fd 
  kio/misc/CMakeLists.txt e2c62d6 
  kio/misc/kpac/CMakeLists.txt 04ffba1 
  kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
  kio/tests/CMakeLists.txt 825ca3c 
  kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
  kjsembed/examples/kjsconsole/CMakeLists.txt 2438323 
  kjsembed/kjscmd/CMakeLists.txt f457933 
  knotify/tests/CMakeLists.txt bc6f5e0 
  kparts/tests/CMakeLists.txt bb8a120 
  kpty/CMakeLists.txt 2cc2885 
  kross/console/CMakeLists.txt 58257ca 
  staging/kde4support/CMakeLists.txt 0445f0a 
  staging/kde4support/src/CMakeLists.txt 6f4603d 
  staging/kemoticons/tests/CMakeLists.txt 5e0d46e 

Diff: http://git.reviewboard.kde.org/r/112570/diff/


Testing
-------

Builds, although it doesn't change much in linux.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/17638894/attachment.html>


More information about the Kde-frameworks-devel mailing list