Review Request 112537: Improve signal emitting in KSelectionOwner

Commit Hook null at kde.org
Mon Sep 9 04:29:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112537/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 4:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Description
-------

I kind of broke it when adjusting to the unit test. We have to wait for the previous owner to destroy its window before emitting the claim signal. If we time out without the window closed, we should emit the failed signal though. Otherwise a client will wait forever. 


Diffs
-----

  tier1/kwindowsystem/src/kmanagerselection.cpp 9623ed6 

Diff: http://git.reviewboard.kde.org/r/112537/diff/


Testing
-------

KWin can replace itself again.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/a7fbde0a/attachment.html>


More information about the Kde-frameworks-devel mailing list