Review Request 112537: Improve signal emitting in KSelectionOwner

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112537/#review39620
-----------------------------------------------------------


This review has been submitted with commit d5454f14f52f8c7cab6c89657bcf70dd19af9867 by Martin Gräßlin to branch frameworks.

- Commit Hook


On Sept. 5, 2013, 2:34 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112537/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 2:34 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> I kind of broke it when adjusting to the unit test. We have to wait for the previous owner to destroy its window before emitting the claim signal. If we time out without the window closed, we should emit the failed signal though. Otherwise a client will wait forever. 
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/kmanagerselection.cpp 9623ed6 
> 
> Diff: http://git.reviewboard.kde.org/r/112537/diff/
> 
> 
> Testing
> -------
> 
> KWin can replace itself again.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/1b94d27d/attachment.html>