Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39538
-----------------------------------------------------------



khtml/khtml_part.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29135>

    Hmm, true, that was a problem with the download() API. People assumed the temp file only existed if download() returns true, but in fact on error, download() returns false and the temp file must still be deleted.
    The new code is much simpler, because the QTemporaryFile object is on the stack with the right scope (which is what was missing with NetAccess::download), let's not propagate the bug there, when the new API makes this just work out of the box.
    
    No need to disable autoremove (and then call remove() by hand) when "auto remove at end of block" is *exactly* what we need.


- David Faure


On Sept. 7, 2013, 3:59 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112559/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Port the rest of kdelibs-frameworks to KIO/Jobs
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/xmlhttprequest.h 6edf708 
>   khtml/ecma/xmlhttprequest.cpp 565b489 
>   khtml/html/html_formimpl.cpp 1a16a77 
>   khtml/khtml_part.cpp 1833e4c 
>   kio/kfile/kpropertiesdialog.cpp 2d2f00e 
>   kross/ui/plugin.cpp f9f23f9 
> 
> Diff: http://git.reviewboard.kde.org/r/112559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130907/bc514024/attachment.html>