<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112559/">http://git.reviewboard.kde.org/r/112559/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112559/diff/2/?file=187660#file187660line1051" style="color: black; font-weight: bold; text-decoration: underline;">khtml/khtml_part.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KHTMLPart::documentSource() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1051</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> if( KIO::NetAccess::download( url(), tmpFile, NULL ) )</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1050</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> tmpFile.setAutoRemove(false);</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, true, that was a problem with the download() API. People assumed the temp file only existed if download() returns true, but in fact on error, download() returns false and the temp file must still be deleted.
The new code is much simpler, because the QTemporaryFile object is on the stack with the right scope (which is what was missing with NetAccess::download), let's not propagate the bug there, when the new API makes this just work out of the box.
No need to disable autoremove (and then call remove() by hand) when "auto remove at end of block" is *exactly* what we need.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On September 7th, 2013, 3:59 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2013, 3:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port the rest of kdelibs-frameworks to KIO/Jobs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/xmlhttprequest.h <span style="color: grey">(6edf708)</span></li>
<li>khtml/ecma/xmlhttprequest.cpp <span style="color: grey">(565b489)</span></li>
<li>khtml/html/html_formimpl.cpp <span style="color: grey">(1a16a77)</span></li>
<li>khtml/khtml_part.cpp <span style="color: grey">(1833e4c)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(2d2f00e)</span></li>
<li>kross/ui/plugin.cpp <span style="color: grey">(f9f23f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112559/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>