Review Request 112495: Move kcrash to tier2

[Martin Klapetek]

On Wed, Sep 4, 2013 at 12:43 PM, Stephen Kelly <steveire at gmail.com> wrote:

> David Faure wrote:
>
> > On Sept. 3, 2013, 8:35 p.m., Martin Klapetek wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> http://git.reviewboard.kde.org/r/112495/
> >> -----------------------------------------------------------
> >>
> >> (Updated Sept. 3, 2013, 8:35 p.m.)
> >>
> >>
> >> Review request for KDE Frameworks.
> >>
> >>
>
> 1) It would be much better if you made several patches for things like
> this.
> One patch to remove the remove_definitions() calls, one patch to add
> Qt5::Gui to the link interface, one patch to add the needed
> find_dependency() calls, and then finally the patch moving the code without
> needing to change it. Reviewers should look for this stuff imo.
>

Fair enough, though these changes were really small (no code needed to be
changed with removing definitions, one line for find_dependency() etc...).


>
> 2) Why did you add Qt5::Gui to the link interface? As far as I can see it
> does not need to be.
>

Because KCrash needs qwindowdefs.h, which is in QtGui and afaiu the link
interface is what sets include paths now, so without Gui it wouldn't build.

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130904/84a7b3aa/attachment-0001.html>