Review Request 112495: Move kcrash to tier2

Stephen Kelly steveire at gmail.com
Wed Sep 4 10:43:40 UTC 2013


David Faure wrote:

> On Sept. 3, 2013, 8:35 p.m., Martin Klapetek wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/112495/
>> -----------------------------------------------------------
>>
>> (Updated Sept. 3, 2013, 8:35 p.m.)
>>
>>
>> Review request for KDE Frameworks.
>>
>>

1) It would be much better if you made several patches for things like this. 
One patch to remove the remove_definitions() calls, one patch to add 
Qt5::Gui to the link interface, one patch to add the needed 
find_dependency() calls, and then finally the patch moving the code without 
needing to change it. Reviewers should look for this stuff imo.

2) Why did you add Qt5::Gui to the link interface? As far as I can see it 
does not need to be.

Thanks,

Steve.





More information about the Kde-frameworks-devel mailing list