Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

[Martin Klapetek]

> On Aug. 30, 2013, 8:54 a.m., David Faure wrote:
> > tier1/kconfig/src/core/kconfigini.cpp, line 522
> > <http://git.reviewboard.kde.org/r/112229/diff/1/?file=184233#file184233line522>
> >
> >     Are you sure about this? Does it work even if the file doesn't exist?
> >     
> >     The check you removed was about missing permissions on the directory where the file would be created. QFileInfo::isWritable is about the permissions on the file itself, seems very different to me.

If the file does not exist, the code path above has "return dir.isDir() && dir.isWritable();", so that checks if the dir where the file would be created is writable too. So that should be ok


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112229/#review38917
-----------------------------------------------------------


On Aug. 23, 2013, 8:02 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112229/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Removes more of direct POSIX calls and replaces them with QT_STUFF.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/src/core/kconfigini.cpp c484ecb 
>   kioslave/ftp/ftp.cpp 1060959 
>   staging/kio/src/widgets/kdirmodel.cpp 77b978a 
>   kioslave/file/file_unix.cpp f4bc812 
>   kdesu/su.cpp f0b1a35 
>   kded/kbuildsycoca.cpp b376a3c 
>   kdesu/client.cpp 5e11f96 
>   tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 903883e 
>   tier1/kcoreaddons/src/lib/io/kprocess.cpp 8f9c1af 
> 
> Diff: http://git.reviewboard.kde.org/r/112229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/ce4205e8/attachment.html>