<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112229/">http://git.reviewboard.kde.org/r/112229/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 30th, 2013, 8:54 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112229/diff/1/?file=184233#file184233line522" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kconfig/src/core/kconfigini.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KConfigIniBackend::isWritable() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">518</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">file</span><span class="p">.</span><span class="n">isWritable</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you sure about this? Does it work even if the file doesn't exist?
The check you removed was about missing permissions on the directory where the file would be created. QFileInfo::isWritable is about the permissions on the file itself, seems very different to me.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the file does not exist, the code path above has "return dir.isDir() && dir.isWritable();", so that checks if the dir where the file would be created is writable too. So that should be ok</pre>
<br />
<p>- Martin</p>
<br />
<p>On August 23rd, 2013, 8:02 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2013, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes more of direct POSIX calls and replaces them with QT_STUFF.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kconfig/src/core/kconfigini.cpp <span style="color: grey">(c484ecb)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(1060959)</span></li>
<li>staging/kio/src/widgets/kdirmodel.cpp <span style="color: grey">(77b978a)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(f4bc812)</span></li>
<li>kdesu/su.cpp <span style="color: grey">(f0b1a35)</span></li>
<li>kded/kbuildsycoca.cpp <span style="color: grey">(b376a3c)</span></li>
<li>kdesu/client.cpp <span style="color: grey">(5e11f96)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: grey">(903883e)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kprocess.cpp <span style="color: grey">(8f9c1af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>