Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists
Commit Hook
null at kde.org
Mon Sep 2 17:55:21 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112453/#review39195
-----------------------------------------------------------
This review has been submitted with commit e4bed2b333b26497c278a5b01ff0e42c817904f1 by Martin Klapetek to branch frameworks.
- Commit Hook
On Sept. 2, 2013, 4:07 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112453/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2013, 4:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> This is a preparation for moving KGuiAddons to tier1/; removes the remove_definitions(..) + fixes the code.
>
>
> Diffs
> -----
>
> staging/kguiaddons/CMakeLists.txt c2e5735
> staging/kguiaddons/src/lib/colors/kcolorcollection.cpp 0ccc500
> staging/kguiaddons/src/lib/colors/kcolormimedata.cpp d0615af
> staging/kguiaddons/src/lib/util/urlhandler.cpp d104aa2
> staging/kguiaddons/src/plugins/eps.cpp e05745e
> staging/kguiaddons/src/plugins/rgb.cpp 4ad8f5b
>
> Diff: http://git.reviewboard.kde.org/r/112453/diff/
>
>
> Testing
> -------
>
> Builds and all tests pass.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/f71da877/attachment.html>
More information about the Kde-frameworks-devel
mailing list