Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112453/#review39181
-----------------------------------------------------------

Ship it!


I suppose QStringLiteral would be better in the places where an actual QString is needed (i.e. no QLatin1String overload available). No big deal, maybe something to keep in mind for future similar work.


staging/kguiaddons/src/lib/colors/kcolorcollection.cpp
<http://git.reviewboard.kde.org/r/112453/#comment28907>

    contains() would be more readable btw, since we don't need the index



staging/kguiaddons/src/lib/colors/kcolorcollection.cpp
<http://git.reviewboard.kde.org/r/112453/#comment28908>

    you can merge the '/' into the "colors/" that follows. This is just the result of a porting script.


- David Faure


On Sept. 2, 2013, 4:07 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112453/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This is a preparation for moving KGuiAddons to tier1/; removes the remove_definitions(..) + fixes the code.
> 
> 
> Diffs
> -----
> 
>   staging/kguiaddons/CMakeLists.txt c2e5735 
>   staging/kguiaddons/src/lib/colors/kcolorcollection.cpp 0ccc500 
>   staging/kguiaddons/src/lib/colors/kcolormimedata.cpp d0615af 
>   staging/kguiaddons/src/lib/util/urlhandler.cpp d104aa2 
>   staging/kguiaddons/src/plugins/eps.cpp e05745e 
>   staging/kguiaddons/src/plugins/rgb.cpp 4ad8f5b 
> 
> Diff: http://git.reviewboard.kde.org/r/112453/diff/
> 
> 
> Testing
> -------
> 
> Builds and all tests pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/511751d8/attachment.html>