Review Request 113498: Fix KCompletion standalone build

Aurélien Gâteau agateau at kde.org
Wed Oct 30 13:26:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113498/
-----------------------------------------------------------

(Updated Oct. 30, 2013, 2:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

This is a 2-commit patches:

- CMakeLists.txt: Format according to CMake template, add QtXml to the dependencies

- kcomboboxtest: Remove dependency on KF5::KIconThemes, it is tier3


Diffs
-----

  superbuild/CMakeLists.txt 3c82e8d 
  tier2/kcompletion/CMakeLists.txt 75e5c52 
  tier2/kcompletion/tests/CMakeLists.txt 8a696c6 
  tier2/kcompletion/tests/kcomboboxtest.cpp e8d068a 

Diff: http://git.reviewboard.kde.org/r/113498/diff/


Testing
-------

Builds within kdelibs and standalone, tests pass.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131030/920d7687/attachment.html>


More information about the Kde-frameworks-devel mailing list