Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

Alexander Richardson arichardson.kde at googlemail.com
Mon Oct 28 20:32:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 8:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Fix KConfigCompiler_Test::testRunning() on Windows

The test expects that the executables to find have no suffix


Diffs
-----

  tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 7f2697ad94ac6d433d18fb16a99ed1435433547d 

Diff: http://git.reviewboard.kde.org/r/113423/diff/


Testing
-------

Test passes.

Although IMO it might make sense to drop this test, it takes ages due to spawning all those programs that do nothing useful.
Compiling these generated files to see that they contain no errors is enough.


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131028/1dd925d4/attachment.html>


More information about the Kde-frameworks-devel mailing list