Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows
Commit Hook
null at kde.org
Mon Oct 28 20:32:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/#review42556
-----------------------------------------------------------
This review has been submitted with commit 0d44382caa78e3e17db0f917f50cc3a9159bf422 by Alex Richardson to branch frameworks.
- Commit Hook
On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113423/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 3:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Fix KConfigCompiler_Test::testRunning() on Windows
>
> The test expects that the executables to find have no suffix
>
>
> Diffs
> -----
>
> tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 7f2697ad94ac6d433d18fb16a99ed1435433547d
>
> Diff: http://git.reviewboard.kde.org/r/113423/diff/
>
>
> Testing
> -------
>
> Test passes.
>
> Although IMO it might make sense to drop this test, it takes ages due to spawning all those programs that do nothing useful.
> Compiling these generated files to see that they contain no errors is enough.
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131028/6a128975/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list