Review Request 113402: Fix KI18n standalone build

Aurélien Gâteau agateau at kde.org
Mon Oct 28 17:28:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113402/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 6:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

KI18n depends on KJS to build the ktranscript plugin. This plugin requires an internal KJS Perl script as well as headers which were not installed.

This is a 3-commit patches, which does the following:

1. Install kjs headers

2. Install wtf headers, using wtf/ and kjs/ in include directives (because some kjs headers includes wtf headers)

3. Fix KI18n:
- Format top-level CMakeLists.txt according to CMake template
- Duplicate KJS create_hash_table script
- Add call to find_package(KJS)

Individual patches available from http://agateau.com/tmp/ki18n-standalone.patch


Diffs
-----

  superbuild/CMakeLists.txt 5cdec94 
  tier1/kjs/src/CMakeLists.txt 8629716 
  tier1/kjs/src/kjs/CMakeLists.txt 9523e89 
  tier1/kjs/src/wtf/CMakeLists.txt 83b4417 
  tier1/kjs/src/wtf/FastMalloc.h 29a72a5 
  tier1/kjs/src/wtf/HashCountedSet.h be3c387 
  tier1/kjs/src/wtf/HashFunctions.h f665447 
  tier1/kjs/src/wtf/HashMap.h ba2971c 
  tier1/kjs/src/wtf/HashSet.h e84b349 
  tier1/kjs/src/wtf/HashTable.h 0b2c22c 
  tier1/kjs/src/wtf/HashTable.cpp e08d09a 
  tier1/kjs/src/wtf/HashTraits.h 4d01726 
  tier1/kjs/src/wtf/ListRefPtr.h 0a704d8 
  tier1/kjs/src/wtf/OwnArrayPtr.h 3b77871 
  tier1/kjs/src/wtf/OwnPtr.h 188a1dc 
  tier1/kjs/src/wtf/PassRefPtr.h 25b9906 
  tier1/kjs/src/wtf/RefPtr.h 493ab05 
  tier1/kjs/src/wtf/Vector.h 9b0f38a 
  tier1/kjs/src/wtf/VectorTraits.h 31ae028 
  tier2/ki18n/CMakeLists.txt 4cc8e30 
  tier2/ki18n/src/CMakeLists.txt 7f8259b4 
  tier2/ki18n/src/create_hash_table PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113402/diff/


Testing
-------

Builds within kdelibs and standalone.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131028/e55c5688/attachment.html>


More information about the Kde-frameworks-devel mailing list