<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113402/">http://git.reviewboard.kde.org/r/113402/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 6:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KI18n depends on KJS to build the ktranscript plugin. This plugin requires an internal KJS Perl script as well as headers which were not installed.
This is a 3-commit patches, which does the following:
1. Install kjs headers
2. Install wtf headers, using wtf/ and kjs/ in include directives (because some kjs headers includes wtf headers)
3. Fix KI18n:
- Format top-level CMakeLists.txt according to CMake template
- Duplicate KJS create_hash_table script
- Add call to find_package(KJS)
Individual patches available from http://agateau.com/tmp/ki18n-standalone.patch</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds within kdelibs and standalone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>superbuild/CMakeLists.txt <span style="color: grey">(5cdec94)</span></li>
<li>tier1/kjs/src/CMakeLists.txt <span style="color: grey">(8629716)</span></li>
<li>tier1/kjs/src/kjs/CMakeLists.txt <span style="color: grey">(9523e89)</span></li>
<li>tier1/kjs/src/wtf/CMakeLists.txt <span style="color: grey">(83b4417)</span></li>
<li>tier1/kjs/src/wtf/FastMalloc.h <span style="color: grey">(29a72a5)</span></li>
<li>tier1/kjs/src/wtf/HashCountedSet.h <span style="color: grey">(be3c387)</span></li>
<li>tier1/kjs/src/wtf/HashFunctions.h <span style="color: grey">(f665447)</span></li>
<li>tier1/kjs/src/wtf/HashMap.h <span style="color: grey">(ba2971c)</span></li>
<li>tier1/kjs/src/wtf/HashSet.h <span style="color: grey">(e84b349)</span></li>
<li>tier1/kjs/src/wtf/HashTable.h <span style="color: grey">(0b2c22c)</span></li>
<li>tier1/kjs/src/wtf/HashTable.cpp <span style="color: grey">(e08d09a)</span></li>
<li>tier1/kjs/src/wtf/HashTraits.h <span style="color: grey">(4d01726)</span></li>
<li>tier1/kjs/src/wtf/ListRefPtr.h <span style="color: grey">(0a704d8)</span></li>
<li>tier1/kjs/src/wtf/OwnArrayPtr.h <span style="color: grey">(3b77871)</span></li>
<li>tier1/kjs/src/wtf/OwnPtr.h <span style="color: grey">(188a1dc)</span></li>
<li>tier1/kjs/src/wtf/PassRefPtr.h <span style="color: grey">(25b9906)</span></li>
<li>tier1/kjs/src/wtf/RefPtr.h <span style="color: grey">(493ab05)</span></li>
<li>tier1/kjs/src/wtf/Vector.h <span style="color: grey">(9b0f38a)</span></li>
<li>tier1/kjs/src/wtf/VectorTraits.h <span style="color: grey">(31ae028)</span></li>
<li>tier2/ki18n/CMakeLists.txt <span style="color: grey">(4cc8e30)</span></li>
<li>tier2/ki18n/src/CMakeLists.txt <span style="color: grey">(7f8259b4)</span></li>
<li>tier2/ki18n/src/create_hash_table <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113402/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>