Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review42333
-----------------------------------------------------------

Ship it!



tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp
<http://git.reviewboard.kde.org/r/112443/#comment30787>

    Maybe add a comment that this is the same a QX11Info::display(), but we don't want to link to QtX11Extras here.



tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp
<http://git.reviewboard.kde.org/r/112443/#comment30786>

    Using "qApp" would work too, after all the display() method already relies on a QGuiApp being used rather than a QCoreApp.


- David Faure


On Oct. 24, 2013, 5:19 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 5:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/CMakeLists.txt e4578aa 
>   tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> -------
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131025/e0d6611e/attachment.html>