Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/
-----------------------------------------------------------

(Updated Oct. 24, 2013, 7:19 a.m.)


Review request for KDE Frameworks.


Changes
-------

Removed the QX11Extras dependency. Please verify that the approach for getting access to the QPA is correct.


Repository: kdelibs


Description
-------

Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.


Diffs (updated)
-----

  tier1/kguiaddons/CMakeLists.txt e4578aa 
  tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd 
  tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
  tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
  tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 

Diff: http://git.reviewboard.kde.org/r/112443/diff/


Testing
-------

used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131024/421ee478/attachment-0001.html>