Review Request 113373: Enable C++11 support by default.

[Kevin Ottens]

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote:
> > As far as I know, only threadweaver and karchive will be released in December. The rest of the frameworks won't be released until summer. 
> > 
> > By summer, CMake 3.0.0 will most likely be out.
> 
> Volker Krause wrote:
>     while the CMake 3 solution is obviously much nicer, what are our alternatives until then? The current solution is adding -std=c++0x without proper compiler checks ad-hoc where needed, I think that's far worse than this change. Also, it wont detect incompatibilities with C++11 in currently C++98-only code paths. And changes here are needed anyway, since -ansi effectively prevents you from enabling C++11 (which also suggests ICC hasn't been tested in quite a while).
>
> 
> Ivan Čukić wrote:
>     +1
> 
> Stephen Kelly wrote:
>     Fair enough.
>     
>     I don't recommend releasing ecm with this though.
>     
>     I don't see any reason to release ecm when releasing KArchive and Threadweaver. I recommend just copying needed files into the first release of those instead.
> 
> Alexander Neundorf wrote:
>     I.e. both will have copies of ECMSetupVersion.cmake, ECMVersionHeader.h.in, KDEInstallDirs.cmake, KDECompilerSettings.cmake and KDECMakeSettings.cmake ?
>     This is just so much against what was originally, at least my, idea of e-c-m: make cmake stuff we have in KDE, but which can be useful also in other projects, easier and quicker available to others (instead of not being able to release it when the first frameworks are released).
>     But I don't object, it's your decision.
>
> 
> Stephen Kelly wrote:
>     It's not my decision either. It's just a recommendation.
> 
> Aleix Pol Gonzalez wrote:
>     I object.
>     What's the big impediment of releasing ECM? If there's an impediment, let's fix it.

I agree with Aleix here. I think it's important that the first frameworks we'll release are as close as possible to the final situation, ECM should be releasable by then. If something blocks that, we should try to solve it.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113373/#review42130
-----------------------------------------------------------


On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113373/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 6:51 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Enable C++11 support by default.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d 
> 
> Diff: http://git.reviewboard.kde.org/r/113373/diff/
> 
> 
> Testing
> -------
> 
> Compiles, all required fixes have been integrated into the frameworks branch by now (at least for the subset I have the required dependencies for).
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131025/3a59c36e/attachment.html>