Review Request 113378: Trivial warning fixes

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113378/
-----------------------------------------------------------

(Updated Oct. 22, 2013, 4:01 p.m.)


Review request for KDE Frameworks.


Changes
-------

Use QVERIFY/QCOMPARE in kactioncategorytest.cpp, rather than Q_UNUSED to hack around Q_ASSERT


Repository: kdelibs


Description
-------

Trivial warning fixes

Fixes for warnings (almost entirely unused variables or parameters)
where the correct fix was obvious.


Diffs (updated)
-----

  interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e 
  khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 
  khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 
  khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b 
  khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 
  khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 
  khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 
  khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 
  khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 
  khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 
  khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c 
  khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 
  khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 
  kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d 
  kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac 
  kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 
  knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 
  staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a 
  staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f 
  staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 
  staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d 
  staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 
  staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 
  staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 
  staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 
  staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 
  staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 
  staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf 
  staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 
  staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b 
  staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f 
  staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e 
  tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 
  tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 
  tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a 
  tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 
  tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 
  tier1/karchive/src/karchive.cpp 375daaaa717bd5030ff694e1586855f1e3f401ef 
  tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f 
  tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 2b5570938f189d4891fa7baa9f9b74791c97f4ad 
  tier1/kwidgetsaddons/src/kdatetable.cpp e5c6f5cbdafaa8ac2abd4f4eea1bb0ef9191b386 
  tier1/kwidgetsaddons/src/kdragwidgetdecorator.cpp 74fb8bbcf3c9836cfd88da1d017b61c4da4deb29 
  tier1/threadweaver/src/Weaver/DestructedState.cpp bcd613201234ca6db19d285d571c4b6fca350789 
  tier1/threadweaver/src/Weaver/JobCollection.cpp bac3d22e25bc2a89cc72278f666fe6e1d0635079 
  tier1/threadweaver/src/Weaver/ShuttingDownState.cpp ff692a59a7f94c123fc225eea9d165ba28bf5d0b 
  tier2/kwallet/src/kwallet.cpp 49098bf5832ff83b270c1934aaf0abf6c4c780a9 
  tier3/kdeclarative/src/bindings/icon.cpp 0d956c500d4a0492025310abad67254fd1a7776e 
  tier3/kinit/src/klauncher/klauncher.cpp 83f98357bd692b13b2a4b812e536acc69372c541 
  tier3/xmlgui/autotests/kactioncategorytest.cpp 2e30b0c53374a2d5677f507550d24588c862af1e 
  tier3/xmlgui/src/khelpmenu.cpp 2b88f406385e8ae8084f6f11ddf824243acfca5e 

Diff: http://git.reviewboard.kde.org/r/113378/diff/


Testing
-------

Builds and tests pass.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131022/d0e3ac5f/attachment-0001.html>