<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113378/">http://git.reviewboard.kde.org/r/113378/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 4:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QVERIFY/QCOMPARE in kactioncategorytest.cpp, rather than Q_UNUSED to hack around Q_ASSERT</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Trivial warning fixes
Fixes for warnings (almost entirely unused variables or parameters)
where the correct fix was obvious.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kimproxy/library/kimproxy.cpp <span style="color: grey">(e48545f0a7229d66d16901c492095ce70b755c7e)</span></li>
<li>khtml/src/css/css_ruleimpl.cpp <span style="color: grey">(e2b3a8ae82ec0f6f85c5949a08f1773b08510479)</span></li>
<li>khtml/src/css/css_webfont.cpp <span style="color: grey">(9c5bedd13a24a3d32f670d718e1ff761ec4a6724)</span></li>
<li>khtml/src/css/cssstyleselector.cpp <span style="color: grey">(fa8f5f4049aec3c2738257215a74b2536981d89b)</span></li>
<li>khtml/src/ecma/kjs_clientrect.cpp <span style="color: grey">(6d7138e7f15293d18406a90eacf214847d884c45)</span></li>
<li>khtml/src/ecma/kjs_events.cpp <span style="color: grey">(d0c481f06ab0efab9457f699571fdd052a99a348)</span></li>
<li>khtml/src/ecma/kjs_proxy.cpp <span style="color: grey">(afd661bd149eaaa2a8ad4940f2a7d61d1f892116)</span></li>
<li>khtml/src/editing/htmlediting_impl.cpp <span style="color: grey">(2ec91188e47748a19ce414cf5d740518b8cf5225)</span></li>
<li>khtml/src/imload/decoders/pngloader.cpp <span style="color: grey">(6d0f023e25cdd112173873bf26b13c2d86172cb8)</span></li>
<li>khtml/src/rendering/RenderSVGRoot.cpp <span style="color: grey">(c1e96d23e12732294301d675b3603f3e86656e56)</span></li>
<li>khtml/src/rendering/render_canvasimage.cpp <span style="color: grey">(73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c)</span></li>
<li>khtml/src/svg/SVGLinearGradientElement.cpp <span style="color: grey">(46059f78527b313e90111cfcc048fc64727fb265)</span></li>
<li>khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp <span style="color: grey">(11c768fc1f496a1cb365bd5fc2ed2e3cada66720)</span></li>
<li>kioslave/file/file.cpp <span style="color: grey">(692a77fe02c33d64ff38afccfd48e8dc3127e75d)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(c8781fef39cf3e842f9c9794d757154d8ae284ac)</span></li>
<li>kioslave/http/http.cpp <span style="color: grey">(b4fd4126dfb86a251d2b98cf587311b715be9979)</span></li>
<li>knewstuff/src/ui/itemsgridviewdelegate.cpp <span style="color: grey">(a0abb7f0b359b06268e4c640be08bfd3ddae79b1)</span></li>
<li>staging/frameworkintegration/src/platformtheme/main.cpp <span style="color: grey">(45b487c739266e4108df8de38ae5e139ca603e5a)</span></li>
<li>staging/kde4support/autotests/kglobalstatictest.cpp <span style="color: grey">(db6473a572d47086e8db400d94c3bf62424f493f)</span></li>
<li>staging/kde4support/src/kdecore/kdebug.cpp <span style="color: grey">(98baed423e2af32d5a6726d21d4d140854b94375)</span></li>
<li>staging/kde4support/src/kdeui/kaction.cpp <span style="color: grey">(f5d2e201b84feea2e0ccba9b17298d3c5877e04d)</span></li>
<li>staging/kde4support/src/kdeui/kapplication.cpp <span style="color: grey">(dc2e120bc28fca5708c699e68ddea22915c46233)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatawidget.cpp <span style="color: grey">(2df231227cd058842b8f1b90b5901cbebadbb683)</span></li>
<li>staging/kde4support/tests/kcmdlineargstest.cpp <span style="color: grey">(a72aa4d120baf2904addd238276e0b400e0d8850)</span></li>
<li>staging/kio/src/core/klocalsocket.h <span style="color: grey">(93b04d69f52ccc16a3dba817d0585835e7134821)</span></li>
<li>staging/kio/src/core/tcpslavebase.cpp <span style="color: grey">(5180ed952d29e995c78cae498f323e0f1a3e08d7)</span></li>
<li>staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp <span style="color: grey">(59c4b37709acd37e9a6d1b77ff233f9e83cdecc8)</span></li>
<li>staging/kio/src/widgets/kdirmodel.cpp <span style="color: grey">(ea290d0369aea303657afb74000780610c135ddf)</span></li>
<li>staging/kio/src/widgets/kurlrequester.cpp <span style="color: grey">(70c760589d460f705c8bb884a5c76e2f9d5dece8)</span></li>
<li>staging/kservice/src/plugin/kpluginfactory.cpp <span style="color: grey">(405d41ed63f8bf4d54334d437f443160c569a82b)</span></li>
<li>staging/kservice/src/plugin/kplugintrader.h <span style="color: grey">(823b8d5dd363642a4c11be971ee64bc3cac6a65f)</span></li>
<li>staging/kservice/tests/pluginlocator/plugintest.cpp <span style="color: grey">(4cfc74ace9c10cccbd2651291e752b8275af036e)</span></li>
<li>tier1/itemmodels/src/kdescendantsproxymodel.cpp <span style="color: grey">(3bdfd9ffed351b5bab24e7959730c29773cc0952)</span></li>
<li>tier1/itemmodels/src/kselectionproxymodel.cpp <span style="color: grey">(ca97070b70996ab1320d252623a503172c9be041)</span></li>
<li>tier1/itemviews/src/kwidgetitemdelegate.cpp <span style="color: grey">(8d4d5cec85ee460fe2604c83fd49bf7536db990a)</span></li>
<li>tier1/itemviews/src/kwidgetitemdelegatepool.cpp <span style="color: grey">(ed94c8936e4db44dc180c5820619a0ca3fdeffa2)</span></li>
<li>tier1/itemviews/tests/kwidgetitemdelegatetest.cpp <span style="color: grey">(07c8bca052a3340322884ba84e8ecdf5386e10a6)</span></li>
<li>tier1/karchive/src/karchive.cpp <span style="color: grey">(375daaaa717bd5030ff694e1586855f1e3f401ef)</span></li>
<li>tier1/kconfig/autotests/test_kconf_update.cpp <span style="color: grey">(78b783042b03dd0a15f8ce91f85ec1415acfc12f)</span></li>
<li>tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp <span style="color: grey">(2b5570938f189d4891fa7baa9f9b74791c97f4ad)</span></li>
<li>tier1/kwidgetsaddons/src/kdatetable.cpp <span style="color: grey">(e5c6f5cbdafaa8ac2abd4f4eea1bb0ef9191b386)</span></li>
<li>tier1/kwidgetsaddons/src/kdragwidgetdecorator.cpp <span style="color: grey">(74fb8bbcf3c9836cfd88da1d017b61c4da4deb29)</span></li>
<li>tier1/threadweaver/src/Weaver/DestructedState.cpp <span style="color: grey">(bcd613201234ca6db19d285d571c4b6fca350789)</span></li>
<li>tier1/threadweaver/src/Weaver/JobCollection.cpp <span style="color: grey">(bac3d22e25bc2a89cc72278f666fe6e1d0635079)</span></li>
<li>tier1/threadweaver/src/Weaver/ShuttingDownState.cpp <span style="color: grey">(ff692a59a7f94c123fc225eea9d165ba28bf5d0b)</span></li>
<li>tier2/kwallet/src/kwallet.cpp <span style="color: grey">(49098bf5832ff83b270c1934aaf0abf6c4c780a9)</span></li>
<li>tier3/kdeclarative/src/bindings/icon.cpp <span style="color: grey">(0d956c500d4a0492025310abad67254fd1a7776e)</span></li>
<li>tier3/kinit/src/klauncher/klauncher.cpp <span style="color: grey">(83f98357bd692b13b2a4b812e536acc69372c541)</span></li>
<li>tier3/xmlgui/autotests/kactioncategorytest.cpp <span style="color: grey">(2e30b0c53374a2d5677f507550d24588c862af1e)</span></li>
<li>tier3/xmlgui/src/khelpmenu.cpp <span style="color: grey">(2b88f406385e8ae8084f6f11ddf824243acfca5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113378/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>