Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113266/
-----------------------------------------------------------

(Updated Oct. 22, 2013, 12:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

This is a 4-commit request which does the following:

- moves plugin handling to kmessagebox_p.*
- fixes loading of plugin (library name was wrong)
- introduces KMessageBoxNotifyInterface
- implements KMessageBoxNotifyInterface in the framework integration plugin.

Individual patches are available here: http://agateau.com/tmp/kmessagebox-notification.patch.mbox (apply with `git am`)


Diffs
-----

  staging/frameworkintegration/src/integrationplugin/CMakeLists.txt d8305bf 
  staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.h ccf44d6 
  staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 
  tier1/kwidgetsaddons/src/CMakeLists.txt 50c578a 
  tier1/kwidgetsaddons/src/kmessagebox.h 9a76c23 
  tier1/kwidgetsaddons/src/kmessagebox.cpp b2345d0 
  tier1/kwidgetsaddons/src/kmessagebox_p.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kmessagebox_p.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kmessageboxnotifyinterface.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113266/diff/


Testing
-------

Ran kmessageboxtest, heard lots of beeps.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131022/846e639a/attachment.html>