<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113266/">http://git.reviewboard.kde.org/r/113266/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 12:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a 4-commit request which does the following:
- moves plugin handling to kmessagebox_p.*
- fixes loading of plugin (library name was wrong)
- introduces KMessageBoxNotifyInterface
- implements KMessageBoxNotifyInterface in the framework integration plugin.
Individual patches are available here: http://agateau.com/tmp/kmessagebox-notification.patch.mbox (apply with `git am`)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran kmessageboxtest, heard lots of beeps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/frameworkintegration/src/integrationplugin/CMakeLists.txt <span style="color: grey">(d8305bf)</span></li>
<li>staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.h <span style="color: grey">(ccf44d6)</span></li>
<li>staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp <span style="color: grey">(b8f5fa7)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(50c578a)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox.h <span style="color: grey">(9a76c23)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox.cpp <span style="color: grey">(b2345d0)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/kmessageboxnotifyinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113266/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>