Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113301/#review41895
-----------------------------------------------------------


This review has been submitted with commit 7b4c83df7f09e3585cfc5f046f3f77653857c495 by David Edmundson to branch frameworks.

- Commit Hook


On Oct. 17, 2013, 5:59 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113301/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 5:59 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Move KGlobalShortcutInfo DBus serialisation to a public header
> 
> -----
> 
> See https://git.reviewboard.kde.org/r/113267/
> 
> Clients in kde-workspace are currently trying to import a private header which completely defeats the point of something being private.
> 
> 
> Diffs
> -----
> 
>   tier3/xmlgui/src/kglobalshortcutinfo.h d1ccd56 
>   tier3/xmlgui/src/kglobalshortcutinfo_p.h 57f2bd5 
> 
> Diff: http://git.reviewboard.kde.org/r/113301/diff/
> 
> 
> Testing
> -------
> 
> Built kde-workspace (with a minor change there)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131017/0d5073aa/attachment.html>