Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113301/#review41873
-----------------------------------------------------------

Ship it!


Looks good to me. It's strange to have exported functions declared in a private header anyway.

- Aurélien Gâteau


On Oct. 17, 2013, 7:59 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113301/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 7:59 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Move KGlobalShortcutInfo DBus serialisation to a public header
> 
> -----
> 
> See https://git.reviewboard.kde.org/r/113267/
> 
> Clients in kde-workspace are currently trying to import a private header which completely defeats the point of something being private.
> 
> 
> Diffs
> -----
> 
>   tier3/xmlgui/src/kglobalshortcutinfo.h d1ccd56 
>   tier3/xmlgui/src/kglobalshortcutinfo_p.h 57f2bd5 
> 
> Diff: http://git.reviewboard.kde.org/r/113301/diff/
> 
> 
> Testing
> -------
> 
> Built kde-workspace (with a minor change there)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131017/56a0f4fd/attachment.html>