Review Request 113182: Remove all the versioned classes of KCategoryDrawer.
David Edmundson
david at davidedmundson.co.uk
Mon Oct 14 10:21:38 UTC 2013
> On Oct. 14, 2013, 8:27 a.m., Kevin Ottens wrote:
> > tier1/itemviews/src/kcategorydrawer.h, line 228
> > <http://git.reviewboard.kde.org/r/113182/diff/1/?file=200162#file200162line228>
> >
> > Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect though...
I tried a typedef first, it caused errors in code using it which had
class KCategoryDrawerV3;
...
#include "kcategorydrawer.h" (which had my typedef in)
Giving the incredibly daft error:
error: 'class KCategoryDrawerV3' has a previous declaration as 'class KCategoryDrawerV3'
The inheritance seemed like the neatest solution.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/#review41679
-----------------------------------------------------------
On Oct. 9, 2013, 4:45 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113182/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2013, 4:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Remove all the versioned classes of KCategoryDrawer.
>
> Remove original KCategoryDrawer and KCategoryDrawerV2 which
> were already deprecated and merge everything into one class which has
> the features of KCategoryDrawerV3 called simply KCategoryDrawer.
>
> Compatability with KCategoryDrawerV3 is left and marked as deprecated.
>
>
> Diffs
> -----
>
> tier1/itemviews/src/kcategorizedview.h c8035c5
> tier1/itemviews/src/kcategorizedview.cpp 35fafae
> tier1/itemviews/src/kcategorizedview_p.h 4c175fb
> tier1/itemviews/src/kcategorydrawer.h e36197b
> tier1/itemviews/src/kcategorydrawer.cpp 0e45e23
> tier1/itemviews/tests/kcategorizedviewtest.cpp 116278c
>
> Diff: http://git.reviewboard.kde.org/r/113182/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131014/9de682ce/attachment.html>
More information about the Kde-frameworks-devel
mailing list