<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113182/">http://git.reviewboard.kde.org/r/113182/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 14th, 2013, 8:27 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113182/diff/1/?file=200162#file200162line228" style="color: black; font-weight: bold; text-decoration: underline;">tier1/itemviews/src/kcategorydrawer.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">KCategoryDrawerV3</span> <span class="o">:</span> <span class="n">public</span> <span class="n">KCategoryDrawer</span> <span class="p">{};</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect though...</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried a typedef first, it caused errors in code using it which had
class KCategoryDrawerV3;
...
#include "kcategorydrawer.h" (which had my typedef in)
Giving the incredibly daft error:
error: 'class KCategoryDrawerV3' has a previous declaration as 'class KCategoryDrawerV3'
The inheritance seemed like the neatest solution.</pre>
<br />
<p>- David</p>
<br />
<p>On October 9th, 2013, 4:45 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2013, 4:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove all the versioned classes of KCategoryDrawer.
Remove original KCategoryDrawer and KCategoryDrawerV2 which
were already deprecated and merge everything into one class which has
the features of KCategoryDrawerV3 called simply KCategoryDrawer.
Compatability with KCategoryDrawerV3 is left and marked as deprecated.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/itemviews/src/kcategorizedview.h <span style="color: grey">(c8035c5)</span></li>
<li>tier1/itemviews/src/kcategorizedview.cpp <span style="color: grey">(35fafae)</span></li>
<li>tier1/itemviews/src/kcategorizedview_p.h <span style="color: grey">(4c175fb)</span></li>
<li>tier1/itemviews/src/kcategorydrawer.h <span style="color: grey">(e36197b)</span></li>
<li>tier1/itemviews/src/kcategorydrawer.cpp <span style="color: grey">(0e45e23)</span></li>
<li>tier1/itemviews/tests/kcategorizedviewtest.cpp <span style="color: grey">(116278c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113182/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>