Review Request 113215: Fix casing in KPty cmake vars

Sebastian Kügler sebas at kde.org
Sun Oct 13 13:09:04 UTC 2013



> On Oct. 13, 2013, 8:36 a.m., David Faure wrote:
> > tier3/kpty/KPtyConfig.cmake.in, line 12
> > <http://git.reviewboard.kde.org/r/113215/diff/2/?file=200894#file200894line12>
> >
> >     and remove this line, see 1628dccc5ebc665bcee518131d427c4e22c89512

IOW: Ditch this patch, it's obsolete. :)

I'll do exactly that.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113215/#review41626
-----------------------------------------------------------


On Oct. 12, 2013, 6:55 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113215/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2013, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KPTY_ vars were set as uppercase, while camelcase is in line with frameworks.
> 
> 
> Diffs
> -----
> 
>   tier3/kpty/KPtyConfig.cmake.in a59bce8 
> 
> Diff: http://git.reviewboard.kde.org/r/113215/diff/
> 
> 
> Testing
> -------
> 
> Fixes a cmake error when trying to build konsole.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131013/a85a8b16/attachment.html>


More information about the Kde-frameworks-devel mailing list