Review Request 113215: Fix casing in KPty cmake vars

David Faure faure at kde.org
Sun Oct 13 08:36:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113215/#review41626
-----------------------------------------------------------



tier3/kpty/KPtyConfig.cmake.in
<http://git.reviewboard.kde.org/r/113215/#comment30430>

    Ah, remove this line, see 2bfc26549e76b8547962ea28aa88f24b544244ff



tier3/kpty/KPtyConfig.cmake.in
<http://git.reviewboard.kde.org/r/113215/#comment30432>

    haha, and remove this line too, see a261751a2534ee5feae75112c601fccb18d2be7f
    
    Massive cleanup by Stephen Kelly :-)



tier3/kpty/KPtyConfig.cmake.in
<http://git.reviewboard.kde.org/r/113215/#comment30431>

    and remove this line, see 1628dccc5ebc665bcee518131d427c4e22c89512


- David Faure


On Oct. 12, 2013, 6:55 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113215/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2013, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KPTY_ vars were set as uppercase, while camelcase is in line with frameworks.
> 
> 
> Diffs
> -----
> 
>   tier3/kpty/KPtyConfig.cmake.in a59bce8 
> 
> Diff: http://git.reviewboard.kde.org/r/113215/diff/
> 
> 
> Testing
> -------
> 
> Fixes a cmake error when trying to build konsole.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131013/9a465003/attachment.html>


More information about the Kde-frameworks-devel mailing list