Review Request 113205: Make KJob::result public for the new signal/slot syntax.

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/
-----------------------------------------------------------

(Updated Oct. 12, 2013, 6:30 p.m.)


Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.


Changes
-------

Updated patch according to comments.
I took the example from: https://codereview.qt-project.org/#patch,all,30337,4

Compiled, ran tests, ran my own test application and everything seems fine with the new signal/slot syntax.


Repository: kdelibs


Description
-------

The new signal/slot connection:
connect(job, &KJob::result,...

does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private

Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.


Diffs (updated)
-----

  tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
  tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f 

Diff: http://git.reviewboard.kde.org/r/113205/diff/


Testing
-------

Works just fine.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131012/2c73cca3/attachment.html>