Review Request 113205: Make KJob::result public for the new signal/slot syntax.
Mark Gaiser
markg85 at gmail.com
Sat Oct 12 14:08:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/
-----------------------------------------------------------
(Updated Oct. 12, 2013, 2:08 p.m.)
Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.
Changes
-------
Added some authors of KJobs.
Repository: kdelibs
Description
-------
The new signal/slot connection:
connect(job, &KJob::result,...
does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private
Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.
Diffs
-----
tier1/kcoreaddons/src/lib/jobs/kjob.h d663530
Diff: http://git.reviewboard.kde.org/r/113205/diff/
Testing
-------
Works just fine.
Thanks,
Mark Gaiser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131012/c355b58f/attachment.html>
More information about the Kde-frameworks-devel
mailing list