Review Request 113199: KHTML: KComponentData -> KAboutData
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Oct 11 12:56:20 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41558
-----------------------------------------------------------
Ship it!
Looks quite straightforward to me, happy to see another kde4support dependency less :).
- Aleix Pol Gonzalez
On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113199/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 12:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KComponentData -> KAboutData
>
> This drops the KDE4Support dependency in KHTML.
>
>
> Diffs
> -----
>
> khtml/src/java/kjavaappletviewer.h 3c3fd77
> khtml/src/java/kjavaappletviewer.cpp cf6acf1
> khtml/src/java/CMakeLists.txt 02efcd8
> khtml/src/CMakeLists.txt dd36945
> khtml/src/khtml_global.h 0d16716
> khtml/src/khtml_global.cpp 4d7c6ca
> khtml/src/khtml_part.cpp 6e7f87e
> khtml/src/khtmlimage.h 9623a2a
> khtml/src/khtmlimage.cpp a074051
>
> Diff: http://git.reviewboard.kde.org/r/113199/diff/
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131011/a4ff0fe0/attachment.html>
More information about the Kde-frameworks-devel
mailing list