Review Request 113199: KHTML: KComponentData -> KAboutData

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41556
-----------------------------------------------------------



khtml/src/khtmlimage.cpp
<http://git.reviewboard.kde.org/r/113199/#comment30370>

    To me, deleting a static member when one instance gets deleted seems rather bad.
    
    However, the original code did it and it must have worked so I've left it the same.
    


- David Edmundson


On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113199/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2013, 12:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KComponentData -> KAboutData
> 
> This drops the KDE4Support dependency in KHTML.
> 
> 
> Diffs
> -----
> 
>   khtml/src/java/kjavaappletviewer.h 3c3fd77 
>   khtml/src/java/kjavaappletviewer.cpp cf6acf1 
>   khtml/src/java/CMakeLists.txt 02efcd8 
>   khtml/src/CMakeLists.txt dd36945 
>   khtml/src/khtml_global.h 0d16716 
>   khtml/src/khtml_global.cpp 4d7c6ca 
>   khtml/src/khtml_part.cpp 6e7f87e 
>   khtml/src/khtmlimage.h 9623a2a 
>   khtml/src/khtmlimage.cpp a074051 
> 
> Diff: http://git.reviewboard.kde.org/r/113199/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131011/1cc5c249/attachment.html>