Review Request 112797: Bring back KStringHandler::naturalCompare()

Aleix Pol Gonzalez aleixpol at kde.org
Wed Oct 9 18:07:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 6:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.


Repository: kdelibs


Description
-------

Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator.


Diffs
-----

  KDE5PORTING.html 88700b0 
  staging/kde4support/autotests/CMakeLists.txt 473bdba 
  staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
  staging/kde4support/src/CMakeLists.txt 51519a3 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
  tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 

Diff: http://git.reviewboard.kde.org/r/112797/diff/


Testing
-------

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131009/3ca65afd/attachment.html>


More information about the Kde-frameworks-devel mailing list