Review Request 113087: Start preparing KHTML for moving

David Edmundson david at davidedmundson.co.uk
Thu Oct 3 22:15:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113087/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Split into /src and /tests
(file moves not shown as it makes the diff even more impossible to read. Diff made with --diff-filter=AM)

Remove references to ${CMAKE_SOURCE_DIR}/khtml/.... which won't work when moved

KComboBox -> QComboBox

If building standalone load kcookieserver dbus interface from system path


---

Still has quite a few other changes left to do, but this will be easier in small chunks (diff is already hard to read)


Diffs
-----

  CMakeLists.txt 3204c11 
  khtml/CMakeLists.txt 91b55a3 
  khtml/KHTMLConfig.cmake.in PRE-CREATION 
  khtml/src/CMakeLists.txt PRE-CREATION 
  khtml/tests/CMakeLists.txt 0a404d5 
  khtml/tests/testkhtml.qrc 4cfe54b 
  khtml/tests/testkhtmlnew.h e7b7205 
  khtml/tests/testkhtmlnew.cpp 525c9fd 
  staging/CMakeLists.txt 5c5c80c 

Diff: http://git.reviewboard.kde.org/r/113087/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/7df6e116/attachment.html>


More information about the Kde-frameworks-devel mailing list