Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/#review41436
-----------------------------------------------------------


It makes sense to me. I would like someone else to approve.

- David Edmundson


On Oct. 8, 2013, 1:20 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113173/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 1:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Modifies how features are checked. This file has some pre-processor macros that are used to checking for OS features. These are defined with "1" if acceptable and undefined if the feature is not present. These macros are being checked with #if, so the pre-processor will complain whenever it's asked about one of the variables that haven't been defined.
> 
> This patch adds a defined() first, before checking the value, so the pre-processor doesn't need to consider the variable value, if it's not present.
> 
> This change makes it possible to read the compilation logs from modules that use KJS.
> 
> 
> Diffs
> -----
> 
>   tier1/kjs/src/wtf/Platform.h 843cfd2 
> 
> Diff: http://git.reviewboard.kde.org/r/113173/diff/
> 
> 
> Testing
> -------
> 
> Builds, KJS tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131009/d7b97ed4/attachment.html>