Reduce warnings noise when including wtf/Platform.h in KJS

Aleix Pol aleixpol at kde.org
Tue Oct 8 14:05:36 UTC 2013


On Tue, Oct 8, 2013 at 3:50 PM, Stephen Kelly <steveire at gmail.com> wrote:

> Stephen Kelly wrote:
>
> >> These are defined with "1" if acceptable and undefined if the feature is
> >> not present.
> >
> > This is the problem that should be fixed.
> >
> > It should be 0 if the feature is not present. Please fix that instead.
>
> Hmm, or maybe your fix is ok.
>
> I don't know where the values come from, but there seems to be a code smell
> somewhere...
>
> Thanks,
>
> Steve.
>
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

If you take a look at the code, you'll see that it's what the original
author meant.

I thought about adding all the alternatives, but I don't think it would
make sense, especially given they are meant to be checked through the
macros.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131008/787d9081/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list