Review Request 113174: Cleanup KJsEmbed

David Edmundson david at davidedmundson.co.uk
Wed Oct 9 16:18:59 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41435
-----------------------------------------------------------



kjsembed/examples/kjsconsole/numberedtextview.cpp
<http://git.reviewboard.kde.org/r/113174/#comment30310>

    why not just do 
    
    width(QString("00001032"))
    
    or maybe this was originally meant to be
    
    fontMetrics().width(QString("0000")) + 10 + 32; ?



kjsembed/kjscmd/kjscmd.cpp
<http://git.reviewboard.kde.org/r/113174/#comment30311>

    this seems to break whitespace for no reason?



staging/kjsembed/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113174/#comment30312>

    It may be better to do 
    
    if (not Qt5UiTools) 
    return
    endif 
    
    so you don't install all the Config.cmake files etc. on something that didn't actually build. 
    
    (see a change stervie did in khtml)


- David Edmundson


On Oct. 8, 2013, 2:09 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113174/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 2:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Adopt directory organization, naming scheme, cmake structures, documents dependencies.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 368584e 
>   kjsembed/AUTHORS  
>   kjsembed/CMakeLists.txt 6cb6727 
>   kjsembed/Mainpage.dox  
>   kjsembed/examples/calc/calc.js  
>   kjsembed/examples/calc/calc.ui  
>   kjsembed/examples/console/console.js  
>   kjsembed/examples/console/console.ui  
>   kjsembed/examples/docviewer/docviewer.js  
>   kjsembed/examples/docviewer/docviewer.ui  
>   kjsembed/examples/fancy/fancy.js  
>   kjsembed/examples/grammar/grammar.js  
>   kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b 
>   kjsembed/examples/kjsconsole/console.h  
>   kjsembed/examples/kjsconsole/console.cpp f65f39b 
>   kjsembed/examples/kjsconsole/console.qrc  
>   kjsembed/examples/kjsconsole/images/bug.png  
>   kjsembed/examples/kjsconsole/images/class.png  
>   kjsembed/examples/kjsconsole/images/constant.png  
>   kjsembed/examples/kjsconsole/images/method.png  
>   kjsembed/examples/kjsconsole/images/next.png  
>   kjsembed/examples/kjsconsole/images/no.png  
>   kjsembed/examples/kjsconsole/images/property.png  
>   kjsembed/examples/kjsconsole/images/runto.png  
>   kjsembed/examples/kjsconsole/images/start.png  
>   kjsembed/examples/kjsconsole/images/step.png  
>   kjsembed/examples/kjsconsole/images/stop.png  
>   kjsembed/examples/kjsconsole/jsconsole.ui  
>   kjsembed/examples/kjsconsole/kjs_object_model.h  
>   kjsembed/examples/kjsconsole/kjs_object_model.cpp  
>   kjsembed/examples/kjsconsole/main.cpp  
>   kjsembed/examples/kjsconsole/numberedtextview.h  
>   kjsembed/examples/kjsconsole/numberedtextview.cpp f144502 
>   kjsembed/examples/scribble/scribble.js  
>   kjsembed/examples/tests/args.js  
>   kjsembed/examples/tests/brush.js  
>   kjsembed/examples/tests/builtins.js  
>   kjsembed/examples/tests/class.js  
>   kjsembed/examples/tests/colortest.js  
>   kjsembed/examples/tests/conio.js  
>   kjsembed/examples/tests/domtest.js  
>   kjsembed/examples/tests/events.js  
>   kjsembed/examples/tests/fileio.js  
>   kjsembed/examples/tests/fonttest.js  
>   kjsembed/examples/tests/frame.js  
>   kjsembed/examples/tests/gc.js  
>   kjsembed/examples/tests/include.js  
>   kjsembed/examples/tests/inner.js  
>   kjsembed/examples/tests/jsslot.js  
>   kjsembed/examples/tests/layout.js  
>   kjsembed/examples/tests/library.js  
>   kjsembed/examples/tests/listproperties.js  
>   kjsembed/examples/tests/matt.js  
>   kjsembed/examples/tests/paintertest.js  
>   kjsembed/examples/tests/paintevent.js  
>   kjsembed/examples/tests/pixmap.js  
>   kjsembed/examples/tests/recttest.js  
>   kjsembed/examples/tests/settings.js  
>   kjsembed/examples/tests/signslots.js  
>   kjsembed/examples/tests/statictest.js  
>   kjsembed/examples/tests/stylesheet.js  
>   kjsembed/examples/tests/svgtest.js  
>   kjsembed/examples/tests/system.js  
>   kjsembed/examples/tests/test.svg  
>   kjsembed/examples/tests/test.ui  
>   kjsembed/examples/tests/typecheck.js  
>   kjsembed/examples/tests/uitest.js  
>   kjsembed/examples/tests/uitest2.js  
>   kjsembed/examples/tests/url.js  
>   kjsembed/examples/tests/widgettest.js  
>   kjsembed/kjscmd/CMakeLists.txt eeb5667 
>   kjsembed/kjscmd/console.js  
>   kjsembed/kjscmd/kjscmd.cpp df833db 
>   kjsembed/kjscmd/kjscmd.qrc  
>   kjsembed/kjsembed/CMakeLists.txt 8089c4b 
>   kjsembed/kjsembed/QBrush_bind.h  
>   kjsembed/kjsembed/QBrush_bind.cpp  
>   kjsembed/kjsembed/application.h  
>   kjsembed/kjsembed/application.cpp  
>   kjsembed/kjsembed/binding_support.h  
>   kjsembed/kjsembed/binding_support.cpp  
>   kjsembed/kjsembed/brush.h  
>   kjsembed/kjsembed/brush.cpp  
>   kjsembed/kjsembed/builtins.h  
>   kjsembed/kjsembed/builtins.cpp  
>   kjsembed/kjsembed/color.h  
>   kjsembed/kjsembed/color.cpp  
>   kjsembed/kjsembed/dom.h  
>   kjsembed/kjsembed/dom.cpp  
>   kjsembed/kjsembed/eventproxy.h  
>   kjsembed/kjsembed/eventproxy.cpp  
>   kjsembed/kjsembed/filedialog_binding.h  
>   kjsembed/kjsembed/filedialog_binding.cpp  
>   kjsembed/kjsembed/fileio.h  
>   kjsembed/kjsembed/fileio.cpp  
>   kjsembed/kjsembed/font.h  
>   kjsembed/kjsembed/font.cpp  
>   kjsembed/kjsembed/image.h  
>   kjsembed/kjsembed/image.cpp  
>   kjsembed/kjsembed/iosupport.h  
>   kjsembed/kjsembed/iosupport.cpp  
>   kjsembed/kjsembed/jseventmapper.h  
>   kjsembed/kjsembed/jseventmapper.cpp  
>   kjsembed/kjsembed/jseventutils.h  
>   kjsembed/kjsembed/jseventutils.cpp  
>   kjsembed/kjsembed/kjseglobal.h  
>   kjsembed/kjsembed/kjseglobal.cpp  
>   kjsembed/kjsembed/kjsembed.h 74dfab8 
>   kjsembed/kjsembed/kjsembed.cpp  
>   kjsembed/kjsembed/object_binding.h  
>   kjsembed/kjsembed/object_binding.cpp  
>   kjsembed/kjsembed/pen.h  
>   kjsembed/kjsembed/pen.cpp  
>   kjsembed/kjsembed/pixmap.h  
>   kjsembed/kjsembed/pixmap.cpp  
>   kjsembed/kjsembed/point.h  
>   kjsembed/kjsembed/point.cpp  
>   kjsembed/kjsembed/pointer.h  
>   kjsembed/kjsembed/qaction_binding.h  
>   kjsembed/kjsembed/qaction_binding.cpp  
>   kjsembed/kjsembed/qformbuilder_binding.h  
>   kjsembed/kjsembed/qformbuilder_binding.cpp  
>   kjsembed/kjsembed/qlayout_binding.h  
>   kjsembed/kjsembed/qlayout_binding.cpp  
>   kjsembed/kjsembed/qobject_binding.h  
>   kjsembed/kjsembed/qobject_binding.cpp  
>   kjsembed/kjsembed/qpainter_binding.h  
>   kjsembed/kjsembed/qpainter_binding.cpp  
>   kjsembed/kjsembed/quiloader_binding.h  
>   kjsembed/kjsembed/quiloader_binding.cpp  
>   kjsembed/kjsembed/qwidget_binding.h  
>   kjsembed/kjsembed/qwidget_binding.cpp  
>   kjsembed/kjsembed/rect.h  
>   kjsembed/kjsembed/rect.cpp  
>   kjsembed/kjsembed/settings.h  
>   kjsembed/kjsembed/settings.cpp  
>   kjsembed/kjsembed/size.h  
>   kjsembed/kjsembed/size.cpp  
>   kjsembed/kjsembed/slotproxy.h 48b88ef 
>   kjsembed/kjsembed/slotproxy.cpp  
>   kjsembed/kjsembed/static_binding.h  
>   kjsembed/kjsembed/static_binding.cpp  
>   kjsembed/kjsembed/svg_binding.h  
>   kjsembed/kjsembed/svg_binding.cpp  
>   kjsembed/kjsembed/test/QByteArray_bind.h  
>   kjsembed/kjsembed/test/QByteArray_bind.cpp  
>   kjsembed/kjsembed/url.h  
>   kjsembed/kjsembed/url.cpp  
>   kjsembed/kjsembed/util.h  
>   kjsembed/kjsembed/value_binding.h  
>   kjsembed/kjsembed/value_binding.cpp  
>   kjsembed/kjsembed/variant_binding.h  
>   kjsembed/kjsembed/variant_binding.cpp  
>   staging/CMakeLists.txt 4f64e8a 
>   staging/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION 
>   staging/kjsembed/src/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kross/src/kjs/CMakeLists.txt cfa026e 
> 
> Diff: http://git.reviewboard.kde.org/r/113174/diff/
> 
> 
> Testing
> -------
> 
> Builds, the test case seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131009/48825633/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list