<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113174/">http://git.reviewboard.kde.org/r/113174/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113174/diff/1/?file=199980#file199980line38" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjsembed/examples/kjsconsole/numberedtextview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setFixedWidth</span><span class="p">(</span> <span class="n">fontMetrics</span><span class="p">().</span><span class="n">width</span><span class="p">(</span> <span class="n">QString</span><span class="p">(</span><span class="s">"0000"</span><span class="p">)</span> <span class="o">+</span> <span class="mi"><span class="hl">10</span></span> <span class="o">+</span> <span class="mi"><span class="hl">32</span></span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setFixedWidth</span><span class="p">(</span> <span class="n">fontMetrics</span><span class="p">().</span><span class="n">width</span><span class="p">(</span> <span class="n">QString</span><span class="p">(</span><span class="s">"0000"</span><span class="p">)</span> <span class="o">+</span> <span class="n"><span class="hl">QString</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">number</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">10</span></span><span class="p"><span class="hl">)</span></span> <span class="o">+</span> <span class="n"><span class="hl">QString</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">number</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">32</span></span><span class="p"><span class="hl">)</span></span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why not just do
width(QString("00001032"))
or maybe this was originally meant to be
fontMetrics().width(QString("0000")) + 10 + 32; ?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113174/diff/1/?file=200020#file200020line78" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjsembed/src/kjscmd/kjscmd.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main( int argc, char **argv )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this seems to break whitespace for no reason?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113174/diff/1/?file=200102#file200102line26" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjsembed/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span> <span class="p">(</span><span class="s">Qt5UiTools_FOUND</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It may be better to do
if (not Qt5UiTools)
return
endif
so you don't install all the Config.cmake files etc. on something that didn't actually build.
(see a change stervie did in khtml)</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On October 8th, 2013, 2:09 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 2:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adopt directory organization, naming scheme, cmake structures, documents dependencies.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, the test case seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(368584e)</span></li>
<li>kjsembed/AUTHORS <span style="color: grey">()</span></li>
<li>kjsembed/CMakeLists.txt <span style="color: grey">(6cb6727)</span></li>
<li>kjsembed/Mainpage.dox <span style="color: grey">()</span></li>
<li>kjsembed/examples/calc/calc.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/calc/calc.ui <span style="color: grey">()</span></li>
<li>kjsembed/examples/console/console.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/console/console.ui <span style="color: grey">()</span></li>
<li>kjsembed/examples/docviewer/docviewer.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/docviewer/docviewer.ui <span style="color: grey">()</span></li>
<li>kjsembed/examples/fancy/fancy.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/grammar/grammar.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/CMakeLists.txt <span style="color: grey">(d06f27b)</span></li>
<li>kjsembed/examples/kjsconsole/console.h <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/console.cpp <span style="color: grey">(f65f39b)</span></li>
<li>kjsembed/examples/kjsconsole/console.qrc <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/bug.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/class.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/constant.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/method.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/next.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/no.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/property.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/runto.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/start.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/step.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/images/stop.png <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/jsconsole.ui <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/kjs_object_model.h <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/kjs_object_model.cpp <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/main.cpp <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/numberedtextview.h <span style="color: grey">()</span></li>
<li>kjsembed/examples/kjsconsole/numberedtextview.cpp <span style="color: grey">(f144502)</span></li>
<li>kjsembed/examples/scribble/scribble.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/args.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/brush.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/builtins.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/class.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/colortest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/conio.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/domtest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/events.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/fileio.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/fonttest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/frame.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/gc.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/include.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/inner.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/jsslot.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/layout.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/library.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/listproperties.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/matt.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/paintertest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/paintevent.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/pixmap.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/recttest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/settings.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/signslots.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/statictest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/stylesheet.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/svgtest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/system.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/test.svg <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/test.ui <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/typecheck.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/uitest.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/uitest2.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/url.js <span style="color: grey">()</span></li>
<li>kjsembed/examples/tests/widgettest.js <span style="color: grey">()</span></li>
<li>kjsembed/kjscmd/CMakeLists.txt <span style="color: grey">(eeb5667)</span></li>
<li>kjsembed/kjscmd/console.js <span style="color: grey">()</span></li>
<li>kjsembed/kjscmd/kjscmd.cpp <span style="color: grey">(df833db)</span></li>
<li>kjsembed/kjscmd/kjscmd.qrc <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/CMakeLists.txt <span style="color: grey">(8089c4b)</span></li>
<li>kjsembed/kjsembed/QBrush_bind.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/QBrush_bind.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/application.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/application.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/binding_support.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/binding_support.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/brush.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/brush.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/builtins.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/builtins.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/color.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/color.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/dom.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/dom.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/eventproxy.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/eventproxy.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/filedialog_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/filedialog_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/fileio.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/fileio.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/font.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/font.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/image.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/image.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/iosupport.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/iosupport.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/jseventmapper.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/jseventmapper.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/jseventutils.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/jseventutils.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/kjseglobal.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/kjseglobal.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/kjsembed.h <span style="color: grey">(74dfab8)</span></li>
<li>kjsembed/kjsembed/kjsembed.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/object_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/object_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/pen.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/pen.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/pixmap.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/pixmap.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/point.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/point.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/pointer.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qaction_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qaction_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qformbuilder_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qformbuilder_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qlayout_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qlayout_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qobject_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qobject_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qpainter_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qpainter_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/quiloader_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/quiloader_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qwidget_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/qwidget_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/rect.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/rect.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/settings.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/settings.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/size.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/size.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/slotproxy.h <span style="color: grey">(48b88ef)</span></li>
<li>kjsembed/kjsembed/slotproxy.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/static_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/static_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/svg_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/svg_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/test/QByteArray_bind.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/test/QByteArray_bind.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/url.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/url.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/util.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/value_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/value_binding.cpp <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/variant_binding.h <span style="color: grey">()</span></li>
<li>kjsembed/kjsembed/variant_binding.cpp <span style="color: grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(4f64e8a)</span></li>
<li>staging/kjsembed/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjsembed/KJsEmbedConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjsembed/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjsembed/src/kjscmd/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjsembed/src/kjsembed/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kross/src/kjs/CMakeLists.txt <span style="color: grey">(cfa026e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>