Review Request 113097: KInit splitting

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113097/#review41265
-----------------------------------------------------------

Ship it!


Nice directory reorganization.


staging/kinit/KInitMacros.cmake
<http://git.reviewboard.kde.org/r/113097/#comment30258>

    yeah clearly this won't work after splitting, or even right now outside of kdelibs.
    
    kde4 was finding it "with the other cmake files from kdelibs/cmake/modules" (installed or uninstalled).
    
    I guess we need the same here. Installing the .in files and in this code "if not in kdelibs -> get_filename_component(_INSTALLED_MODULE_PATH  ${CMAKE_CURRENT_LIST_FILE} PATH)
    (the var name can be whatever).


- David Faure


On Oct. 4, 2013, 2:48 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113097/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Adapts KInit to be moved to its tier, there's still work to do.
> 
> The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE macro.
> Also I reorganized the source code in different directories, so it's easier to figure out.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3204c11 
>   KDE5PORTING.html 88700b0 
>   cmake/modules/kde4init_dummy.cpp.in  
>   cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b 
>   kded/CMakeLists.txt 5a09a3a 
>   kinit/CMakeLists.txt 2e26d91 
>   kinit/ConfigureChecks.cmake  
>   kinit/Info.plist.template  
>   kinit/Mainpage.dox  
>   kinit/README  
>   kinit/README.autostart  
>   kinit/README.wrapper  
>   kinit/autostart.h  
>   kinit/autostart.cpp  
>   kinit/config-kdeinit.h.cmake  
>   kinit/kinit.cpp  
>   kinit/kinit_win.cpp  
>   kinit/kioslave.cpp  
>   kinit/klauncher.h  
>   kinit/klauncher.cpp  
>   kinit/klauncher_adaptor.h  
>   kinit/klauncher_adaptor.cpp  
>   kinit/klauncher_cmds.h  
>   kinit/klauncher_cmds.cpp  
>   kinit/klauncher_main.cpp  
>   kinit/kwrapper.cpp d43ffc7 
>   kinit/kwrapper_win.cpp  
>   kinit/proctitle.h  
>   kinit/proctitle.cpp  
>   kinit/shell.cpp ccb42ed 
>   kinit/start_kdeinit.c  
>   kinit/start_kdeinit_wrapper.c  
>   kinit/wrapper.cpp  
>   kioslave/http/CMakeLists.txt 5dfcbce 
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kinit/CMakeLists.txt PRE-CREATION 
>   staging/kinit/KInitMacros.cmake PRE-CREATION 
>   staging/kinit/src/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION 
>   staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION 
>   tier1/kwindowsystem/src/CMakeLists.txt 00c92de 
> 
> Diff: http://git.reviewboard.kde.org/r/113097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131005/0beaef88/attachment.html>