<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113097/">http://git.reviewboard.kde.org/r/113097/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice directory reorganization.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113097/diff/1/?file=199250#file199250line20" style="color: black; font-weight: bold; text-decoration: underline;">staging/kinit/KInitMacros.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c">#</span><span class="cs">TODO</span><span class="c">: stop hardcoding the path</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah clearly this won't work after splitting, or even right now outside of kdelibs.
kde4 was finding it "with the other cmake files from kdelibs/cmake/modules" (installed or uninstalled).
I guess we need the same here. Installing the .in files and in this code "if not in kdelibs -> get_filename_component(_INSTALLED_MODULE_PATH ${CMAKE_CURRENT_LIST_FILE} PATH)
(the var name can be whatever).</pre>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On October 4th, 2013, 2:48 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2013, 2:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adapts KInit to be moved to its tier, there's still work to do.
The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE macro.
Also I reorganized the source code in different directories, so it's easier to figure out.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3204c11)</span></li>
<li>KDE5PORTING.html <span style="color: grey">(88700b0)</span></li>
<li>cmake/modules/kde4init_dummy.cpp.in <span style="color: grey">()</span></li>
<li>cmake/modules/kde4init_win32lib_dummy.cpp.in <span style="color: grey">(0aa704b)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(5a09a3a)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(2e26d91)</span></li>
<li>kinit/ConfigureChecks.cmake <span style="color: grey">()</span></li>
<li>kinit/Info.plist.template <span style="color: grey">()</span></li>
<li>kinit/Mainpage.dox <span style="color: grey">()</span></li>
<li>kinit/README <span style="color: grey">()</span></li>
<li>kinit/README.autostart <span style="color: grey">()</span></li>
<li>kinit/README.wrapper <span style="color: grey">()</span></li>
<li>kinit/autostart.h <span style="color: grey">()</span></li>
<li>kinit/autostart.cpp <span style="color: grey">()</span></li>
<li>kinit/config-kdeinit.h.cmake <span style="color: grey">()</span></li>
<li>kinit/kinit.cpp <span style="color: grey">()</span></li>
<li>kinit/kinit_win.cpp <span style="color: grey">()</span></li>
<li>kinit/kioslave.cpp <span style="color: grey">()</span></li>
<li>kinit/klauncher.h <span style="color: grey">()</span></li>
<li>kinit/klauncher.cpp <span style="color: grey">()</span></li>
<li>kinit/klauncher_adaptor.h <span style="color: grey">()</span></li>
<li>kinit/klauncher_adaptor.cpp <span style="color: grey">()</span></li>
<li>kinit/klauncher_cmds.h <span style="color: grey">()</span></li>
<li>kinit/klauncher_cmds.cpp <span style="color: grey">()</span></li>
<li>kinit/klauncher_main.cpp <span style="color: grey">()</span></li>
<li>kinit/kwrapper.cpp <span style="color: grey">(d43ffc7)</span></li>
<li>kinit/kwrapper_win.cpp <span style="color: grey">()</span></li>
<li>kinit/proctitle.h <span style="color: grey">()</span></li>
<li>kinit/proctitle.cpp <span style="color: grey">()</span></li>
<li>kinit/shell.cpp <span style="color: grey">(ccb42ed)</span></li>
<li>kinit/start_kdeinit.c <span style="color: grey">()</span></li>
<li>kinit/start_kdeinit_wrapper.c <span style="color: grey">()</span></li>
<li>kinit/wrapper.cpp <span style="color: grey">()</span></li>
<li>kioslave/http/CMakeLists.txt <span style="color: grey">(5dfcbce)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(5c5c80c)</span></li>
<li>staging/kinit/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/KInitMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/kdeinit/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/kioslave/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/klauncher/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/kshell/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/kwrapper/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kinit/src/start_kdeinit/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(00c92de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113097/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>