Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

Teo Mrnjavac teo at kde.org
Fri Oct 4 12:02:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/
-----------------------------------------------------------

(Updated Oct. 4, 2013, 12:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Kevin Ottens.


Repository: kdelibs


Description
-------

Now that https://codereview.qt-project.org/#change,63345 is merged, this commit replaces usage of setNameFilters in some QFileDialog instances in favor of setMimeTypeFilters to avoid repeating the same conversion from mime types to globs in multiple places.


Diffs
-----

  staging/kde4support/src/kssl/kcm/cacertificatespage.cpp e0a66c54633f457322729eecc0395baae8a5c548 
  kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 

Diff: http://git.reviewboard.kde.org/r/113095/diff/


Testing
-------


Thanks,

Teo Mrnjavac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131004/68002517/attachment.html>


More information about the Kde-frameworks-devel mailing list