Review Request 113043: Codestyle changes for kdesu
Commit Hook
null at kde.org
Thu Oct 3 12:05:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113043/#review41173
-----------------------------------------------------------
This review has been submitted with commit 9c89befc359467a480e29289d39d251e06025d8a by Martin Klapetek to branch frameworks.
- Commit Hook
On Oct. 3, 2013, 11:21 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113043/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 11:21 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> As discussed at the frameworks meeting, here's the codestyle change for kdesu. It follows the defined kdelibs coding style. Also removes commented qDebug code and does a micro-optimization in couple places.
>
> With this the code is so much more readable and consistent.
>
>
> Diffs
> -----
>
> staging/kdesu/src/client.h b5dc5e9
> staging/kdesu/src/client.cpp df1268e
> staging/kdesu/src/defaults.h 706a088
> staging/kdesu/src/kcookie.h f7ecca3
> staging/kdesu/src/kcookie.cpp 58b470a
> staging/kdesu/src/kdesu_stub.c 2de76d4
> staging/kdesu/src/process.h 8bcc655
> staging/kdesu/src/process.cpp 0a4dcf1
> staging/kdesu/src/ssh.h 5de00a6
> staging/kdesu/src/ssh.cpp c4586cf
> staging/kdesu/src/stub.h 13a5e92
> staging/kdesu/src/stub.cpp d827394
> staging/kdesu/src/su.h a7d0e99
> staging/kdesu/src/su.cpp 77eb071
>
> Diff: http://git.reviewboard.kde.org/r/113043/diff/
>
>
> Testing
> -------
>
> All builds.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/d460515b/attachment.html>
More information about the Kde-frameworks-devel
mailing list