<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113043/">http://git.reviewboard.kde.org/r/113043/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9c89befc359467a480e29289d39d251e06025d8a by Martin Klapetek to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 3rd, 2013, 11:21 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2013, 11:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed at the frameworks meeting, here's the codestyle change for kdesu. It follows the defined kdelibs coding style. Also removes commented qDebug code and does a micro-optimization in couple places.
With this the code is so much more readable and consistent.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kdesu/src/client.h <span style="color: grey">(b5dc5e9)</span></li>
<li>staging/kdesu/src/client.cpp <span style="color: grey">(df1268e)</span></li>
<li>staging/kdesu/src/defaults.h <span style="color: grey">(706a088)</span></li>
<li>staging/kdesu/src/kcookie.h <span style="color: grey">(f7ecca3)</span></li>
<li>staging/kdesu/src/kcookie.cpp <span style="color: grey">(58b470a)</span></li>
<li>staging/kdesu/src/kdesu_stub.c <span style="color: grey">(2de76d4)</span></li>
<li>staging/kdesu/src/process.h <span style="color: grey">(8bcc655)</span></li>
<li>staging/kdesu/src/process.cpp <span style="color: grey">(0a4dcf1)</span></li>
<li>staging/kdesu/src/ssh.h <span style="color: grey">(5de00a6)</span></li>
<li>staging/kdesu/src/ssh.cpp <span style="color: grey">(c4586cf)</span></li>
<li>staging/kdesu/src/stub.h <span style="color: grey">(13a5e92)</span></li>
<li>staging/kdesu/src/stub.cpp <span style="color: grey">(d827394)</span></li>
<li>staging/kdesu/src/su.h <span style="color: grey">(a7d0e99)</span></li>
<li>staging/kdesu/src/su.cpp <span style="color: grey">(77eb071)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>