Review Request 113073: Make KColorSpaces really private

Aurélien Gâteau agateau at kde.org
Thu Oct 3 11:44:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113073/
-----------------------------------------------------------

(Updated Oct. 3, 2013, 11:44 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

KColorSpaces is private, suffix its header with "_p" and don't export code from it.


Diffs
-----

  tier1/kguiaddons/src/lib/colors/kcolorspaces.h f21631a 
  tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 8808278 
  tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h PRE-CREATION 
  tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 2fa1960 

Diff: http://git.reviewboard.kde.org/r/113073/diff/


Testing
-------

Builds, tests pass.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/408e2d6a/attachment.html>


More information about the Kde-frameworks-devel mailing list