Review Request 113073: Make KColorSpaces really private

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113073/#review41169
-----------------------------------------------------------


This review has been submitted with commit 12fff0dce46ba1a7b802cd186c2ee956f8f7cb6c by Aurélien Gâteau to branch frameworks.

- Commit Hook


On Oct. 3, 2013, 9:32 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113073/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KColorSpaces is private, suffix its header with "_p" and don't export code from it.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/src/lib/colors/kcolorspaces.h f21631a 
>   tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 8808278 
>   tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h PRE-CREATION 
>   tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 2fa1960 
> 
> Diff: http://git.reviewboard.kde.org/r/113073/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/86d07116/attachment-0001.html>