Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

David Edmundson david at davidedmundson.co.uk
Wed Oct 2 19:12:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112923/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 7:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Make leftMargin rightMargin virtual methods in KCategoryDrawer

Currently KCategoryDrawer operates on a setter/getter for margins
but setting the height and painting is all set by overriding methods

This makes everything consistent.

--

This was marked as a KDE5 TODO


Diffs
-----

  KDE5PORTING.html 57ecf2e 
  tier1/itemviews/src/kcategorydrawer.h 3665457 
  tier1/itemviews/src/kcategorydrawer.cpp 0fb857e 

Diff: http://git.reviewboard.kde.org/r/112923/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/6bd0eb0e/attachment.html>


More information about the Kde-frameworks-devel mailing list