Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112923/#review41145
-----------------------------------------------------------


This review has been submitted with commit d58a96548bf5af0352969f92ef8cd31b1f28a0e4 by David Edmundson to branch frameworks.

- Commit Hook


On Sept. 24, 2013, 11:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112923/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 11:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Make leftMargin rightMargin virtual methods in KCategoryDrawer
> 
> Currently KCategoryDrawer operates on a setter/getter for margins
> but setting the height and painting is all set by overriding methods
> 
> This makes everything consistent.
> 
> --
> 
> This was marked as a KDE5 TODO
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html 57ecf2e 
>   tier1/itemviews/src/kcategorydrawer.h 3665457 
>   tier1/itemviews/src/kcategorydrawer.cpp 0fb857e 
> 
> Diff: http://git.reviewboard.kde.org/r/112923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/df9cae11/attachment.html>