Review Request 113043: Codestyle changes for kdesu

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113043/#review41089
-----------------------------------------------------------


As RB seems to not like this patch at all, I'll wait for the kdesu move patch[0] to be shipped first, then I'll reupload this.

[0] - http://git.reviewboard.kde.org/r/113038/

- Martin Klapetek


On Oct. 1, 2013, 11:14 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113043/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 11:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> As discussed at the frameworks meeting, here's the codestyle change for kdesu. It follows the defined kdelibs coding style. Also removes commented qDebug code and does a micro-optimization in couple places.
> 
> With this the code is so much more readable and consistent.
> 
> 
> Diffs
> -----
> 
>   staging/kdesu/src/client.h PRE-CREATION 
>   staging/kdesu/src/client.cpp PRE-CREATION 
>   staging/kdesu/src/defaults.h PRE-CREATION 
>   staging/kdesu/src/kcookie.h PRE-CREATION 
>   staging/kdesu/src/kcookie.cpp PRE-CREATION 
>   staging/kdesu/src/kdesu_stub.c PRE-CREATION 
>   staging/kdesu/src/process.h PRE-CREATION 
>   staging/kdesu/src/process.cpp PRE-CREATION 
>   staging/kdesu/src/ssh.h PRE-CREATION 
>   staging/kdesu/src/ssh.cpp PRE-CREATION 
>   staging/kdesu/src/stub.h PRE-CREATION 
>   staging/kdesu/src/stub.cpp PRE-CREATION 
>   staging/kdesu/src/su.h PRE-CREATION 
>   staging/kdesu/src/su.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113043/diff/
> 
> 
> Testing
> -------
> 
> All builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131001/8b8580b5/attachment.html>