Review Request 113043: Codestyle changes for kdesu

Martin Klapetek martin.klapetek at gmail.com
Tue Oct 1 23:14:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113043/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

As discussed at the frameworks meeting, here's the codestyle change for kdesu. It follows the defined kdelibs coding style. Also removes commented qDebug code and does a micro-optimization in couple places.

With this the code is so much more readable and consistent.


Diffs
-----

  staging/kdesu/src/client.h PRE-CREATION 
  staging/kdesu/src/client.cpp PRE-CREATION 
  staging/kdesu/src/defaults.h PRE-CREATION 
  staging/kdesu/src/kcookie.h PRE-CREATION 
  staging/kdesu/src/kcookie.cpp PRE-CREATION 
  staging/kdesu/src/kdesu_stub.c PRE-CREATION 
  staging/kdesu/src/process.h PRE-CREATION 
  staging/kdesu/src/process.cpp PRE-CREATION 
  staging/kdesu/src/ssh.h PRE-CREATION 
  staging/kdesu/src/ssh.cpp PRE-CREATION 
  staging/kdesu/src/stub.h PRE-CREATION 
  staging/kdesu/src/stub.cpp PRE-CREATION 
  staging/kdesu/src/su.h PRE-CREATION 
  staging/kdesu/src/su.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113043/diff/


Testing
-------

All builds.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131001/2d9d90ad/attachment.html>


More information about the Kde-frameworks-devel mailing list